Increase maximum runspace pool size in flaky test#1358
Merged
bergmeister merged 2 commits intomasterfrom Jan 16, 2020
Merged
Conversation
6 tasks
Collaborator
Author
|
re-trigger ci |
JamesWTruher
approved these changes
Jan 16, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Increase maximum number over time until we find a stable upper limit. It turns out one cannot do a straightforward calculation of runspaces (either due to complexity or garbage collection)
An example build failure with 14 runspaces is here: https://ci.appveyor.com/project/PowerShell/psscriptanalyzer/builds/28399656/job/8d7spi13o6kekjaw?fullLog=true
cc @thomasrayner for visiblity
PR Checklist
.cs,.ps1and.psm1files have the correct copyright headerWIP:to the beginning of the title and remove the prefix when the PR is ready.